CI: Use setup-msvc-dev action instead of hardcoding the VS install path on Windows - #4861
Merged
Conversation
The Windows runner image upgrade moved Visual Studio from "...\2022\Enterprise\..." to "...\18\Enterprise\...", breaking the hardcoded vcvars64.bat path (see PR #4860). Use the TheMrMilchmann/setup-msvc-dev action instead, which locates the VS installation dynamically via vswhere and exports the environment to later steps, so future runner image upgrades don't require another hardcoded-path fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seisman
added
maintenance
seisman
force-pushed
the
ci/setup-msvc-dev
branch
from
August 25, 2026 08:45
d94bdce to
9f47d7f
Compare
weiji14
approved these changes
Aug 26, 2026
| if: runner.os == 'Windows' | ||
| uses: TheMrMilchmann/setup-msvc-dev@368ef7d1ee4d1171b31d4a7f67f4d954f903f5a9 # v4.1.0 | ||
| with: | ||
| arch: x64 |
Member
There was a problem hiding this comment.
Not an issue now, but we might need to set an or statement to the arch to x86_arm64 or amd64_arm64 when #3911 lands.
seisman
enabled auto-merge (squash)
August 27, 2026 01:19
seisman
disabled auto-merge
August 27, 2026 01:19
seisman
removed
needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows runner image upgrade moved Visual Studio from "...\2022\Enterprise..." to "...\18\Enterprise...", breaking the hardcoded vcvars64.bat path (see PR #4860).
This PR uses the
TheMrMilchmann/setup-msvc-devaction, which locates the VS installation dynamically viavswhereand exports the environment to later steps, so future runner image upgrades don't require another hardcoded-path fix.Supersedes #4860.